Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-popper-tooltip and @popperjs/core for react17 #13434

Conversation

matamatanot
Copy link
Contributor

Issue:
My projects use react@17.

yarn install
warning @storybook/addon-actions > @storybook/components > react-popper-tooltip@3.1.0" has incorrect peer dependency "react-dom@^16.6.0".

What I did

Update dependancies.

x-refs

@matamatanot
Copy link
Contributor Author

matamatanot commented Dec 11, 2020

Other warings.(my case)

react-inspector@5.1.0 Not yet (@storybook/addon-actions)
storybookjs/react-inspector#121

react-helmet-async@1.0.7 Not yet (@storybook/react > @storybook/core > @storybook/ui)
staylor/react-helmet-async#107

react-sizeme@2.6.12 Not yet (@storybook/react > @storybook/core > @storybook/ui)
ctrlplusb/react-sizeme#202

create-react-context@0.3.0 Not yet (@storybook/addon-actions > @storybook/api > @reach/router)
jamiebuilds/create-react-context#32

@reach/router@1.3.4 Not yet (@storybook/addon-actions > @storybook/api)
reach/router#436

@shilman shilman added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 11, 2020
@shilman shilman added this to the 6.1.x milestone Dec 11, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are awesome @matamatanot. Thank you!

CI seems to be failing but hopefully unrelated to this PR. Trying again...

@matamatanot matamatanot changed the title Update react-popper-tooltip for react17 Update react-popper-tooltip and @popperjs/core for react17 Dec 11, 2020
@@ -5233,13 +5233,6 @@
resolved "https://registry.yarnpkg.com/@types/util-deprecate/-/util-deprecate-1.0.0.tgz#341d0815fe5a661b94e3ea738d182b4c359e3958"
integrity sha512-I2vixiQ+mrmKxfdLNvaa766nulrMVDoUQiSQoNeTjFUNAt8klnMgDh3yy/bH/r275357q30ACOEUaxFOR8YVrA==

"@types/webpack-bundle-analyzer@^3.9.0":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part the reason for the failure?
I couldn't see @types/webpack-bundle-analyzer in the stale lockfile diff of popper-core.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it was an intermittent failure. We run so many builds that every now and then something gets corrupted. It seems to have fixed itself when I re-ran the job.

@shilman shilman merged commit fe212ea into storybookjs:next Dec 12, 2020
shilman added a commit that referenced this pull request Dec 12, 2020
…ip-for-react-17

Update react-popper-tooltip and @popperjs/core for react17
@matamatanot matamatanot deleted the upgrade-react-popper-tooltip-for-react-17 branch December 30, 2020 19:01
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants