Prevent rerender when a button callback returns false. (#7197)

Prevent rerender when a button callback returns false.
storybookjs · Jul 31, 2019 · 4b98d59 · 4b98d59
1 parent fc0e049
commit 4b98d59
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/addons/knobs/README.md b/addons/knobs/README.md
@@ -412,6 +412,9 @@ const groupId = 'GROUP-ID1';
 button(label, handler, groupId);
 ```
 
+Button knobs cause the story to re-render after the handler fires, you can prevent
+this by having the handler return false.
+
 ### withKnobs options
 
 withKnobs also accepts two optional options as story parameters.

diff --git a/addons/knobs/src/registerKnobs.js b/addons/knobs/src/registerKnobs.js
@@ -44,8 +44,9 @@ function knobChanged(change) {
 
 function knobClicked(clicked) {
   const knobOptions = knobStore.get(clicked.name);
-  knobOptions.callback();
-  forceReRender();
+  if (knobOptions.callback() !== false) {
+    forceReRender();
+  }
 }
 
 function resetKnobs() {