Merge pull request #18642 from storybookjs/future/improve-linting-a-bit

Future - improve linting a bit

lib/ui/package.json

@@ -87,6 +87,7 @@
     "react-helmet-async": "^1.0.7",
     "react-sizeme": "^3.0.1",
     "resolve-from": "^5.0.0",
+    "shelljs": "^0.8.5",
     "store2": "^2.12.0",
     "ts-dedent": "^2.0.0",
     "typescript": "~4.6.3",

lib/ui/scripts/generate-exports-file.ts

@@ -1,8 +1,7 @@
-/* eslint-disable camelcase */
 /* eslint-disable no-console */
 import fs from 'fs-extra';
 import path from 'path';
-import child_process from 'child_process';
+import shelljs from 'shelljs';
 import { dedent } from 'ts-dedent';
 
 const remove = (regex?: RegExp) => (input: string) =>
@@ -30,15 +29,10 @@ const run = async () => {
   );
 
   console.log('Linting...');
-  child_process.exec(
-    `yarn lint:js:cmd --fix ${location}`,
-    {
-      cwd: path.join(__dirname, '..', '..', '..'),
-    },
-    () => {
-      console.log('Done!');
-    }
-  );
+  shelljs.exec(`yarn lint:js:cmd --fix ${location}`, {
+    cwd: path.join(__dirname, '..', '..', '..'),
+  });
+  console.log('Done!');
 };
 
 run().catch((e) => {

package.json

@@ -67,7 +67,7 @@
     "linear-export": "ts-node --project=./scripts/tsconfig.json ./scripts/linear-export.ts",
     "lint": "yarn lint:js && yarn lint:md",
     "lint:ejs": "ejslint **/*.ejs",
-    "lint:js": "yarn lint:js:cmd .",
+    "lint:js": "yarn lint:js:cmd .  --quiet",
     "lint:js:cmd": "cross-env NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives",
     "lint:md": "remark -q .",
     "lint:package": "sort-package-json",

yarn.lock

@@ -9877,6 +9877,7 @@ __metadata:
     react-helmet-async: ^1.0.7
     react-sizeme: ^3.0.1
     resolve-from: ^5.0.0
+    shelljs: ^0.8.5
     store2: ^2.12.0
     ts-dedent: ^2.0.0
     typescript: ~4.6.3