Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Close server when e2e test failed #10868

Merged
merged 1 commit into from
May 22, 2020
Merged

Core: Close server when e2e test failed #10868

merged 1 commit into from
May 22, 2020

Conversation

tooppaaa
Copy link
Contributor

Issue:
When multiple configs are run on the same node, if the first one fail, the second will show "ADDR already in use"

What I did

Close server on catch

@tooppaaa tooppaaa added maintenance User-facing maintenance tasks core labels May 22, 2020
@tooppaaa tooppaaa self-assigned this May 22, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@shilman shilman merged commit 70e9c44 into next May 22, 2020
@tooppaaa tooppaaa deleted the fix/e2eOnThrow branch May 22, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants