Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix manager-builder tsconfig to emit react-jsx #28541

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

williamhelmrath
Copy link
Contributor

@williamhelmrath williamhelmrath commented Jul 10, 2024

Closes #20968

What I did

Updated the builder tsconfig to emit react-jsx.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Ran a few TS sandboxes and clicked around, addons seemed to work and no relevant errors appeared in console.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 699 B 1.75 0%
initSize 198 MB 198 MB 1.12 kB -1.08 0%
diffSize 121 MB 121 MB 420 B -1.09 0%
buildSize 7.59 MB 7.59 MB 0 B 0.33 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B - 0%
buildSbPreviewSize 349 kB 349 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B - 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0.33 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 20s 7s -13s -33ms -0.85 -186.1%
generateTime 25.5s 23.1s -2s -385ms 0.26 -10.3%
initTime 25.7s 23.5s -2s -163ms 0.12 -9.2%
buildTime 16.2s 13s -3s -171ms -1.06 -24.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.5s 8.4s -93ms -0.12 -1.1%
devManagerResponsive 5.6s 5.5s -99ms -0.14 -1.8%
devManagerHeaderVisible 843ms 734ms -109ms -1.23 -14.9%
devManagerIndexVisible 884ms 767ms -117ms -1.12 -15.3%
devStoryVisibleUncached 1.2s 1.3s 110ms 0.04 8.2%
devStoryVisible 920ms 789ms -131ms -1.18 -16.6%
devAutodocsVisible 730ms 687ms -43ms -0.75 -6.3%
devMDXVisible 797ms 706ms -91ms -0.55 -12.9%
buildManagerHeaderVisible 783ms 689ms -94ms -1.15 -13.6%
buildManagerIndexVisible 786ms 690ms -96ms -1.16 -13.9%
buildStoryVisible 836ms 728ms -108ms -1.27 🔰-14.8%
buildAutodocsVisible 769ms 643ms -126ms -0.81 -19.6%
buildMDXVisible 673ms 654ms -19ms -0.29 -2.9%

@williamhelmrath williamhelmrath changed the title Change addon jsx to react-jsx Update builder tsconfig to emit react-jsx Jul 10, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated /code/core/assets/server/addon.tsconfig.json to change JSX emit mode from 'react' to 'react-jsx'
  • Aligns with latest React standards
  • Improves compatibility with modern React features

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@williamhelmrath williamhelmrath changed the title Update builder tsconfig to emit react-jsx Core: update builder tsconfig to emit react-jsx Jul 12, 2024
@shilman shilman added api: addons maintenance User-facing maintenance tasks ci:normal labels Jul 15, 2024
Copy link

nx-cloud bot commented Jul 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 121c448. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen changed the title Core: update builder tsconfig to emit react-jsx Core: Fix manager-builder tsconfig to emit react-jsx Jul 16, 2024
@ndelangen ndelangen merged commit 3d6f63f into storybookjs:next Jul 16, 2024
50 of 55 checks passed
@ndelangen
Copy link
Member

Thank you @williamhelmrath

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: manager-build tsconfig jsx setting
4 participants