Save filter expression and Create filter set with given label name from add filter modal #7

abdulloh76 · 2022-01-27T11:29:57Z

Save filter expression and Create filter set with given label name from add filter modal

Add Save as filter option for filter expression in dashboard search bar
Bug FIx: old filters from filter bar disappear when add new ones
When user gives label name in add filter modal it is automatically saved as filter set and will be added to filter bar with label name

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

stratoula

This looks good. Thanx a lot! I am merging it

fixes [#8](elastic/observability-accessibility#8) fixes [#7](elastic/observability-accessibility#7) ## Summary Fixes APM breadcrumbs on serverless | Serverless | Stateful | |---|---| | <img width="700px" alt="image" src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2"> |<img width="800px" alt="image" src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2"> |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">| | <img width="500px" alt="image" src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2"> |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/cb8a39e2-ca33-4cf9-a8ac-4c84566d092d">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/151a3a9c-c81e-4558-9d00-e695e3d1d79c">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/2562e96f-d5e4-4aa4-a221-6721f8995883">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/8d877d11-8c3f-4ac5-8146-6a11125eae7c">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/36e588cb-4c18-4d66-a2c6-f0e66392f708">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/14253196-06de-4343-811f-61aa31ea0d1e">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/0cdfc83f-6545-433f-8c14-5bbf2a581175">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/89a58e2b-2cef-4188-b2be-f359ba6890db">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/f15e767f-5b60-4485-ac71-7b6fd850ec50">| |<img width="500px" alt="image" src="https://github.com/user-attachments/assets/a0f7bfae-bfda-4f49-b92a-e736d80fea4c">|<img width="500px" alt="image" src="https://github.com/user-attachments/assets/680db8ab-58b8-454b-a0d7-6e1681dbe616">| ### How to test #### Serverless - Start a local ES serverless instance: `yarn es serverless --projectType=oblt --ssl -k/--insecure` - Start a local Kibana serverless instance: ` yarn start --serverless=oblt --no-ssl` - Run some synthtrace scenarios - `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts --live --target=https://elastic_serverless:changeme@127.0.0.1:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601` - `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts --live --target=https://elastic_serverless:changeme@127.0.0.1:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601` - Navigate to Applications and click through the links ### Stateful - Start a local ES and Kibana instance - Run the some synthtrace scenarios: - `node scripts/synthtrace mobile.ts --live` - `node scripts/synthtrace service_map.ts --live` - Navigate to Applications and click through the links --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

abdulloh76 added 7 commits January 27, 2022 16:26

start implementing save filter expression feature

16e1666

fix: old filters disappear when adding new ones

4b73a80

feat: create a badge with submited label name

4cd190e

fix: saving all filters instead of one choosen

c0085d8

Merge branch 'attach-filter-label' into save-filter-expression

6cfd159

autosave when filters submitted with label name

14ad606

make save filter panel optional

a450419

abdulloh76 changed the title ~~save filter expression~~ Save filter expression and Create filter set with given label name from add filter modal Jan 31, 2022

abdulloh76 added 3 commits February 1, 2022 11:57

fix: increase id of added filter when already have filters on bar

c6cd316

refactor: checkthe filters field for undefined

36f8dbd

fix: when saved filter-badge it should be replaced with label name

7db4095

abdulloh76 marked this pull request as ready for review February 1, 2022 16:48

refactor: naming of function

338550b

nlatipov approved these changes Feb 2, 2022

View reviewed changes

stratoula approved these changes Feb 2, 2022

View reviewed changes

stratoula merged commit b36fd9e into stratoula:unified-search-poc Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Save filter expression and Create filter set with given label name from add filter modal #7

Save filter expression and Create filter set with given label name from add filter modal #7

abdulloh76 commented Jan 27, 2022 •

edited

Loading

stratoula left a comment

Save filter expression and Create filter set with given label name from add filter modal #7

Save filter expression and Create filter set with given label name from add filter modal #7

Conversation

abdulloh76 commented Jan 27, 2022 • edited Loading