Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Try to fix cache failures when running GH actions #3604

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

bellini666
Copy link
Member

@bellini666 bellini666 commented Aug 24, 2024

  • Make env.pythonLocation as part of the cache key, as suggested by [GitHub Action] python is not installed into the virtualenv wntrblm/nox#735 (comment)
  • Remove the generic option from restore cache to avoid the same issues we had before
  • Use uv as the default venv backend for a performance improvement when installing packages (updated nox for this)
  • Remove strategy: fail-fast in some places where we are not using matrix, and thus this was not doing anything

Summary by Sourcery

Improve GitHub Actions caching by incorporating env.pythonLocation into the cache key and removing unnecessary restore cache options. Enhance performance by setting uv as the default venv backend in nox and streamline CI configuration by removing redundant fail-fast strategies.

Enhancements:

  • Set uv as the default virtual environment backend in nox for improved package installation performance.

CI:

  • Include env.pythonLocation in the cache key to address cache failures in GitHub Actions.
  • Remove the generic restore cache option to prevent previous cache issues.
  • Remove strategy: fail-fast from jobs that do not use a matrix, as it was redundant.

@bellini666 bellini666 self-assigned this Aug 24, 2024
Copy link
Contributor

sourcery-ai bot commented Aug 24, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@bellini666 bellini666 marked this pull request as draft August 24, 2024 13:51
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bellini666 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (cafc388) to head (923a530).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
+ Coverage   93.86%   96.59%   +2.72%     
==========================================
  Files         522      526       +4     
  Lines       32870    34028    +1158     
  Branches     3753     5627    +1874     
==========================================
+ Hits        30854    32869    +2015     
+ Misses       1719      922     -797     
+ Partials      297      237      -60     

@bellini666 bellini666 force-pushed the fix_gh_actions_cache_failures branch 6 times, most recently from 61bc11f to b031426 Compare August 24, 2024 14:15
Copy link

codspeed-hq bot commented Aug 24, 2024

CodSpeed Performance Report

Merging #3604 will not alter performance

Comparing fix_gh_actions_cache_failures (923a530) with main (cafc388)

Summary

✅ 15 untouched benchmarks

@bellini666 bellini666 force-pushed the fix_gh_actions_cache_failures branch 3 times, most recently from 2970425 to 4659406 Compare August 24, 2024 15:13
@botberry
Copy link
Member

botberry commented Aug 24, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@bellini666 bellini666 force-pushed the fix_gh_actions_cache_failures branch 8 times, most recently from 742a056 to e5fbd7c Compare August 25, 2024 12:49
@bellini666 bellini666 force-pushed the fix_gh_actions_cache_failures branch from e5fbd7c to 0b7e5a1 Compare August 25, 2024 12:51
@bellini666
Copy link
Member Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bellini666 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@bellini666 bellini666 marked this pull request as ready for review August 25, 2024 13:00
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It looks like we've already reviewed the commit 0b7e5a1 in this pull request.

@botberry
Copy link
Member

botberry commented Aug 25, 2024

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

@patrick91
Copy link
Member

@bellini666 looks like it is an issue with the latest version of starlette 🤔

@patrick91 patrick91 force-pushed the fix_gh_actions_cache_failures branch from a7fbc55 to 923a530 Compare August 30, 2024 14:51
@patrick91 patrick91 merged commit 26fa597 into main Aug 30, 2024
109 of 110 checks passed
@patrick91 patrick91 deleted the fix_gh_actions_cache_failures branch August 30, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants