-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Try to fix cache failures when running GH actions #3604
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3604 +/- ##
==========================================
+ Coverage 93.86% 96.59% +2.72%
==========================================
Files 522 526 +4
Lines 32870 34028 +1158
Branches 3753 5627 +1874
==========================================
+ Hits 30854 32869 +2015
+ Misses 1719 922 -797
+ Partials 297 237 -60 |
61bc11f
to
b031426
Compare
CodSpeed Performance ReportMerging #3604 will not alter performanceComparing Summary
|
2970425
to
4659406
Compare
Apollo Federation Subgraph Compatibility Results
Learn more: |
742a056
to
e5fbd7c
Compare
e5fbd7c
to
0b7e5a1
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. It looks like we've already reviewed the commit 0b7e5a1 in this pull request.
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature. Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text:
|
@bellini666 looks like it is an issue with the latest version of starlette 🤔 |
a7fbc55
to
923a530
Compare
env.pythonLocation
as part of the cache key, as suggested by [GitHub Action] python is not installed into the virtualenv wntrblm/nox#735 (comment)uv
as the default venv backend for a performance improvement when installing packages (updated nox for this)strategy: fail-fast
in some places where we are not using matrix, and thus this was not doing anythingSummary by Sourcery
Improve GitHub Actions caching by incorporating
env.pythonLocation
into the cache key and removing unnecessary restore cache options. Enhance performance by settinguv
as the default venv backend in nox and streamline CI configuration by removing redundantfail-fast
strategies.Enhancements:
uv
as the default virtual environment backend in nox for improved package installation performance.CI:
env.pythonLocation
in the cache key to address cache failures in GitHub Actions.strategy: fail-fast
from jobs that do not use a matrix, as it was redundant.