Add support for PyRight #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
+ Coverage 97.55% 97.57% +0.01%
==========================================
Files 88 88
Lines 3319 3335 +16
Branches 477 478 +1
==========================================
+ Hits 3238 3254 +16
Misses 45 45
Partials 36 36 |
patrick91
force-pushed
the
feature/pylance
branch
from
71c3d3e
to
e8f02d7
Compare
patrick91
force-pushed
the
feature/pylance
branch
from
e35205b
to
585c4cc
Compare
patrick91
force-pushed
the
feature/pylance
branch
from
de0c489
to
3b77f3b
Compare
patrick91
force-pushed
the
feature/pylance
branch
from
5298b31
to
6cf7534
Compare
patrick91
force-pushed
the
feature/pylance
branch
from
39d97b5
to
2fe67db
Compare
|
Hi 👋 You can find a preview of the docs here: |
patrick91
commented
Sep 1, 2021
patrick91
commented
Sep 1, 2021
strawberry/federation.py
Outdated
| federation=FederationFieldParams( | ||
| provides=provides or [], requires=requires or [], external=external | ||
| ), | ||
| ) | ||
| ) # type: ignore |
There was a problem hiding this comment.
sadly, both mypy and pyright fail here :(
|
Thanks for adding the Here's a preview of the changelog: This release adds support for Pyright and Pylance, improving the Here's the preview release card for twitter: Here's the tweet text: |
patrick91
force-pushed
the
feature/pylance
branch
from
430b65c
to
89b5ecd
Compare
jkimbo
suggested changes
Sep 2, 2021
Co-authored-by: Jonathan Kim <jkimbo@gmail.com>
PyRight might implement implicit init support: microsoft/pyright#2256 🥳🥳🥳
patrick91
force-pushed
the
feature/pylance
branch
from
e5b2697
to
67031eb
Compare
|
Going to wait for this issue to be solved before merging this PR 😊 microsoft/pyright#2256 |
jkimbo
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for pyright following the specification outlined here:
https://github.com/microsoft/pyright/blob/master/specs/dataclass_transforms.md and here: microsoft/pyright#1782
The specification is still work in progress, but there's no harm in supporting it.
As you see from our discussion here we might never get full support for pyright:
microsoft/pyright#1782 (comment)
I've implemented the suggestedWe got support for not having to pass init! 😊initparameter workaround, maybe in future we can get rid of it :)Types of Changes