Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ask about railway crossings on private roads [requires retesting] #1366

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Do not ask about railway crossings on private roads [requires retesting] #1366

merged 2 commits into from
Apr 3, 2019

Conversation

matkoniecz
Copy link
Member

fixes #1321

@matkoniecz matkoniecz changed the title Do not ask about railway crossings on private roads [WIP, BROKEN Do not ask about railway crossings on private roads Apr 2, 2019
@matkoniecz matkoniecz changed the title Do not ask about railway crossings on private roads Do not ask about railway crossings on private roads [ready for review] Apr 2, 2019
@matkoniecz matkoniecz mentioned this pull request Apr 2, 2019
Closed
@matkoniecz
Copy link
Member Author 

FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:connectedDebugAndroidTest'.
> There were failing tests. See the report at: file:///home/travis/build/westnordost/StreetComplete/app/build/reports/androidTests/connected/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 58s

Well, my local build worked well so it seems that it is not a problem introduced by PR.

Also, master branch is failing anyway.

@westnordost
Copy link
Member

I find Travis CI really annoying, perhaps I will disable it. It always fails for some reason and only there. I stopped paying attention to this.

westnordost
westnordost requested changes Apr 3, 2019
View reviewed changes
.../java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrierForm.kt Outdated Show resolved Hide resolved
...n/java/de/westnordost/streetcomplete/quests/railway_crossing/RailwayCrossingBarrierAnswer.kt Outdated Show resolved Hide resolved
...main/java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrier.kt Outdated Show resolved Hide resolved
...main/java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrier.kt Outdated Show resolved Hide resolved
...main/java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrier.kt Outdated Show resolved Hide resolved
...main/java/de/westnordost/streetcomplete/quests/railway_crossing/AddRailwayCrossingBarrier.kt Outdated Show resolved Hide resolved
@matkoniecz
Copy link
Member Author

Thanks for a review, especially nice Kotlin-related things!

@matkoniecz matkoniecz changed the title Do not ask about railway crossings on private roads [ready for review] Do not ask about railway crossings on private roads [requires retesting] Apr 3, 2019
@westnordost
Copy link
Member

I want to release the v11.0 in an hour or so. If you can guarantee that the overpass query is correct and working, I can merge it right away.

@westnordost westnordost self-requested a review April 3, 2019 13:26
@westnordost
Copy link
Member

So did you check?

@matkoniecz
Copy link
Member Author

Yes, I just completed checking and it quest query works fine.

What happens during quest solving was not tested.

@matkoniecz
Copy link
Member Author

Though given that it is a minor detail it can wait without trouble for the next release.

@westnordost
Copy link
Member

Well the quest-solving did not change, so I can merge it

@westnordost westnordost merged commit d5c7688 into streetcomplete:master Apr 3, 2019
@matkoniecz matkoniecz deleted the exclude_private branch April 3, 2019 13:56
@matkoniecz matkoniecz mentioned this pull request May 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westnordost westnordost westnordost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not ask "How is this railway crossing protected?" on railway crossings on private roads
2 participants
@matkoniecz @westnordost