Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Update upgrade/downgrade files after 0.39.0 release and enable KRaftStrimziDowngradeST #9506

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Jan 4, 2024

Type of change

  • Enhancement

Description

This PR updates upgrade/downgrade files after the 0.39.0 release. It also enables KRaftStrimziDowngradeST, which was blocked until new version of Strimzi, which supports KRaft to KRaft upgrade/(safe) downgrade is not released.

Checklist

  • Make sure all tests pass

@im-konge im-konge self-assigned this Jan 4, 2024
@im-konge im-konge added this to the 0.40.0 milestone Jan 4, 2024
@im-konge
Copy link
Member Author

im-konge commented Jan 4, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@im-konge
Copy link
Member Author

im-konge commented Jan 5, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Jan 5, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Jan 5, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Jan 6, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Jan 6, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Jan 7, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍 very nice and clean PR :))

Copy link
Contributor

@jankalinic jankalinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…ngradeST

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

test fixups

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

checkstyle

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

remove the random part

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

fixups to tests, Henrich's comment, common method for removing KafkaTopics + some helper methods

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

different approach in isUnidirectionalTopicOperatorUsed

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

remove building of connect image for upgrade, correct check for expected kafkatopics

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

empty connectImage parameter in azp and specify namespace for continuous clients

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

remove connectImage from parameters and add it to default_variables.yaml

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
Copy link
Member Author

im-konge commented Jan 8, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit ba4180e into strimzi:main Jan 8, 2024
17 checks passed
@im-konge im-konge deleted the bump-up-down branch January 8, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants