Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store secrets and configmaps in folders during log collecting #9659

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Feb 8, 2024

Type of change

  • Refactoring

Description

Due to mess in collected logs this PR gets configmaps and secrets into a sub-folders to keep log folder for failed tests cleaner

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys added this to the 0.40.0 milestone Feb 8, 2024
@kornys kornys requested a review from Frawless February 8, 2024 10:43
Signed-off-by: David Kornel <kornys@outlook.com>
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kornys kornys added the ready for merge Label for PRs which are ready for merge label Feb 8, 2024
@scholzj
Copy link
Member

scholzj commented Feb 8, 2024

/azp run acceptance

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit f82686b into strimzi:main Feb 8, 2024
15 checks passed
@kornys kornys deleted the log-folders branch February 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants