Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] Refactor methods in AbstractST #9661

Merged
merged 2 commits into from
Feb 26, 2024
Merged

[ST] Refactor methods in AbstractST #9661

merged 2 commits into from
Feb 26, 2024

Conversation

jankalinic
Copy link
Contributor

Type of change

  • Refactoring

Description

This pull request serves as a follow-up to the refactoring of AbstractST. In this iteration, the focus is on moving methods that aren't extensively utilized by most tests. By relocating these methods to more appropriate locations, we aim to enhance code organization and ensure that AbstractST contains only the most relevant and commonly used methods.

Checklist

  • Write tests
  • Make sure all tests pass
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@jankalinic jankalinic changed the title [ST] Refactor methods in [ST] Refactor methods in AbstractST Feb 8, 2024
@jankalinic jankalinic self-assigned this Feb 8, 2024
@jankalinic jankalinic added this to the 0.40.0 milestone Feb 8, 2024
@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=acceptance

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: acceptance
GROUPS:
TEST_CASE:
TOTAL: 33
PASS: 33
FAIL: 0
SKIP: 0
BUILD_NUMBER: 5
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

im-konge
im-konge reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR :)

Few comments. I know that most of the things are not from you, but in case we are refactoring these classes, we should also consider removing old stuff, doing the things in more "modern" way, and check if everything is really needed (or correctly named).

systemtest/src/main/java/io/strimzi/systemtest/utils/StUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/StUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/VerificationUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/StUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/VerificationUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/VerificationUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/VerificationUtils.java Outdated Show resolved Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/VerificationUtils.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/operators/user/UserST.java Outdated Show resolved Hide resolved
@Frawless
Copy link
Member

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

see-quick
see-quick approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Assuming the test pass.

@jankalinic
refactor done with rebase
3ac3ea2 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic
fix javadoc
f67085f 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@im-konge
Copy link
Member

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jankalinic jankalinic added the ready for merge Label for PRs which are ready for merge label Feb 26, 2024
@jankalinic
Copy link
Contributor Author

Tests pass, only one test which fails is now common failure - testCruiseControlDuringBrokerScaleUpAndDown which is not caused by this PR and is being worked on

@im-konge im-konge merged commit e7cf213 into strimzi:main Feb 26, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@see-quick see-quick see-quick approved these changes

@henryZrncik henryZrncik henryZrncik approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@jankalinic jankalinic

Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jankalinic @strimzi-ci @Frawless @im-konge @see-quick @henryZrncik