Add topicId to KafkaTopic status #9708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should close strimzi#9651. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tombentley
approved these changes
Feb 19, 2024
| @@ -37,4 +38,13 @@ public String getTopicName() { | |||
| public void setTopicName(String topicName) { | |||
| this.topicName = topicName; | |||
| } | |||
|
|
|||
| @Description("Topic id") | |||
There was a problem hiding this comment.
We're exposing this to client applications. We should try to define what it means so such applications can use it correctly. This is a bit tricky because we have the possibility of conflicting KafkaTopics. I think this is OK:
Suggested change
| @Description("Topic id") | |
| @Description("The topic's id. For a KafkaTopic with the ready condition, this will change only if the topic gets deleted and recreated with the same name.") |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #9651.