Skip to content

Commit

Permalink
Revert Role fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
saurabhbhatia-stripe committed Oct 10, 2024
1 parent a6b1a34 commit c75cffb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/smokescreen/smokescreen.go
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ func checkACLsForRequest(config *Config, req *http.Request, destination hostport
if err != nil {
config.Log.WithFields(logrus.Fields{
"error": err,
"Role": role,
"role": role,
}).Warn("EgressAcl.Decide returned an error.")

config.MetricsClient.Incr("acl.decide_error", 1)
Expand Down
4 changes: 2 additions & 2 deletions pkg/smokescreen/smokescreen_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,7 @@ func TestCONNECTProxyACLs(t *testing.T) {
entry := findCanonicalProxyDecision(logHook.AllEntries())
r.NotNil(entry)
r.Equal("connect proxy host not allowed in rule", entry.Data["decision_reason"])
r.Equal("test-external-connect-proxy-blocked-srv", entry.Data["Role"])
r.Equal("test-external-connect-proxy-blocked-srv", entry.Data["role"])
r.Equal(false, entry.Data["allow"])
})

Expand Down Expand Up @@ -1380,7 +1380,7 @@ func TestCONNECTProxyACLs(t *testing.T) {
entry := findCanonicalProxyDecision(logHook.AllEntries())
r.NotNil(entry)
r.Equal("host matched allowed domain in rule", entry.Data["decision_reason"])
r.Equal("test-external-connect-proxy-allowed-srv", entry.Data["Role"])
r.Equal("test-external-connect-proxy-allowed-srv", entry.Data["role"])
r.Equal(true, entry.Data["allow"])
})

Expand Down

0 comments on commit c75cffb

Please sign in to comment.