Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SmokeScreen Context Fields Public #234

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

saurabhbhatia-stripe
Copy link
Contributor

@saurabhbhatia-stripe saurabhbhatia-stripe commented Oct 10, 2024

Summary

Made Smokescreen Context Fields public

@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11276624797

Details

  • 29 of 38 (76.32%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 54.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smokescreen/smokescreen.go 29 38 76.32%
Totals Coverage Status
Change from base Build 11232466094: -0.02%
Covered Lines: 1436
Relevant Lines: 2634

💛 - Coveralls

@saurabhbhatia-stripe saurabhbhatia-stripe changed the title Make SmokeScreen Fields Public Make SmokeScreen Context Fields Public Oct 10, 2024
@saurabhbhatia-stripe saurabhbhatia-stripe merged commit 688e70b into master Oct 11, 2024
9 checks passed
@saurabhbhatia-stripe saurabhbhatia-stripe deleted the saurabhbhatia/smokescreen-ctx-changes branch October 11, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants