Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Go module support #774

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Revert Go module support #774

merged 1 commit into from
Jan 16, 2019

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Jan 16, 2019

Reverts:
#712

(And an earlier PR that added a go.mod file in the first place.)

Unfortunately, there are still some fairly bad incompatibilities between
Go modules and Dep for users still on the latter. For now, we're going
to revert Go module support because there doesn't seem to be any easy
way (i.e., anything that's not maintaining a fork) of doing a good job
of both. Projects can still use the Go module system, but will have to
pull this package in as a pre-module incompatible one.

We are hoping to eventually see basic module awareness merged into Dep:

golang/dep#1963

If/when that gets done, we'll revert this revert after a small grace
period, and hopefully be back to a place where both packaging systems
are well supported.

I'll also modify the README to clarify the current situation in another
follow up PR.

r? @brandur (WIP.)

brandur-stripe pushed a commit that referenced this pull request Jan 16, 2019
Go module support will be reverted in #774. Here, we update the README
with some information about the status of Go modules in stripe-go, and
how to use the library with them for the time being.
@brandur-stripe
Copy link
Contributor

brandur-stripe commented Jan 16, 2019

@SamWhited Does everything here look okay to you?

It's basically a revert of your patch with a couple additional changes:

  • go.mod has been removed completely.
  • I kept your change in removing go.sum from .gitignore.
  • (Update) Kept changes to .travis.yml.

Thanks!

.travis.yml Outdated Show resolved Hide resolved
brandur-stripe pushed a commit that referenced this pull request Jan 16, 2019
Go module support will be reverted in #774. Here, we update the README
with some information about the status of Go modules in stripe-go, and
how to use the library with them for the time being.
@SamWhited
Copy link
Contributor

SamWhited commented Jan 16, 2019

One little nit (see comment inline), but otherwise LGTM. Thanks for all your hard work on this; sorry to waste so much of your time with a patch that ended up having to be reverted. I'll keep the dep issues in mind when pushing for other packages to update in the future.

Reverts:
#712

(And an earlier PR that added a `go.mod` file in the first place.)

Unfortunately, there are still some fairly bad incompatibilities between
Go modules and Dep for users still on the latter. For now, we're going
to revert Go module support because there doesn't seem to be any easy
way (i.e., anything that's not maintaining a fork) of doing a good job
of both. Projects can still use the Go module system, but will have to
pull this package in as a pre-module incompatible one.

We are hoping to eventually see basic module awareness merged into Dep:

golang/dep#1963

If/when that gets done, we'll revert this revert after a small grace
period, and hopefully be back to a place where both packaging systems
are well supported.

I'll also modify the README to clarify the current situation in another
follow up PR.
@brandur-stripe
Copy link
Contributor

One little nit, but otherwise LGTM. Thanks for all your hard work on this; sorry to waste so much of your time with a patch that ended up having to be reverted. I'll keep the dep issues in mind when pushing for other packages to update in the future.

No worries at all. I don't think the time and effort was wasted because hopefully before too long we'll just be reverting this back and it'll be back in mainline with probably very little changed.

Thanks for your hard work on this and the helpful support!

@brandur-stripe brandur-stripe merged commit e09c7e1 into master Jan 16, 2019
@brandur-stripe brandur-stripe deleted the brandur-revert-modules branch January 16, 2019 22:05
@brandur-stripe
Copy link
Contributor

Released as 55.10.0.

brandur-stripe pushed a commit that referenced this pull request Jan 16, 2019
Go module support will be reverted in #774. Here, we update the README
with some information about the status of Go modules in stripe-go, and
how to use the library with them for the time being.
brandur-stripe pushed a commit that referenced this pull request Jan 16, 2019
Go module support will be reverted in #774. Here, we update the README
with some information about the status of Go modules in stripe-go, and
how to use the library with them for the time being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants