feat: support loadBalancerIP config in relay gateway service #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stevenaldinger I have updated the charts to have these changes. Appreciate the suggestions. Since we manage internally we don't use external pull requests, but hopefully this accommodates your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw your
CONTRIBUTING.mdsays you're not taking contributions, and I'm hoping you consider this PR anyway or reproduce it yourselves in a way you're comfortable with.I'd like to use this chart but without a
loadBalancerIPconfiguration option, there's no way to use aLoadBalancertype service with a static IP (our preferred way to deploy), you're forced to use ephemeral each time.The strategy used in this PR is analogous to the stable nginx-ingress helm chart which can be found here: https://github.com/helm/charts/blob/master/stable/nginx-ingress/templates/controller-service.yaml#L31-L33