Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional ServiceAccount resource #4

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

MattMencel
Copy link

No description provided.

@wrenhunter wrenhunter self-assigned this Feb 1, 2023
@MattMencel
Copy link
Author

Alternatively... if the serviceAccountName in the Deployment is configurable with a value, the ServiceAccount could be provisioned separately from this helm chart.

@wrenhunter wrenhunter merged commit 2896e94 into strongdm:main Feb 3, 2023
Copy link
Contributor

@wrenhunter wrenhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt, this looks good, thanks for the contribution!

@MattMencel
Copy link
Author

@wrenhunter Thanks!

I did forget to update the README. Is there another process to update the helm repo with the updated chart?

@MattMencel MattMencel deleted the serviceaccount branch February 3, 2023 19:30
@wrenhunter
Copy link
Contributor

Hi @MattMencel, we plan to update the README with some other stuff, and can add a note about the ServiceAccount. Is that what you meant by updating the repo further, or something else?

@MattMencel
Copy link
Author

@wrenhunter I don't see the new chart yet in the Helm Repo. So just wondered when it would be published.

helm search repo strongdm                                                                                                                                                                                                             
NAME               	CHART VERSION	APP VERSION	DESCRIPTION
strongdm/sdm-client	0.1.0        	1.0.0      	strongDM Client Container
strongdm/sdm-relay 	0.1.1        	1.0.0      	strongDM Relay

@wrenhunter
Copy link
Contributor

@MattMencel I see what you mean. I'll need to track down a colleague with access to Artifact, so that we can push the changes. I'll let you know when that happens, probably next week.

@wrenhunter
Copy link
Contributor

Hi @MattMencel, the Artifact repo is updated. We're seeing an issue with the repo icons there, but no effect on your update, we'll get that sorted this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants