Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Dockerfile with php7.1-fpm + apache2. php is from the official… #1

Merged
merged 1 commit into from
Apr 18, 2017
Merged

update Dockerfile with php7.1-fpm + apache2. php is from the official… #1

merged 1 commit into from
Apr 18, 2017

Conversation

jeffctr
Copy link
Contributor

@jeffctr jeffctr commented Apr 10, 2017

update Dockerfile with php7.1-fpm + apache2. PHP is from the official PHP Dockerfile.

I update the Dockerfile because this file was too old, in addition, this image is coming from the official repository.

Note: I don't know how many repositories are pointing to this Dockerfile but with this change, it means that we should change every repository that is pointing to this one. I know that Explore in pointing to this one for that reason I update Explore's Docker file.

@ncraike
Copy link
Contributor

ncraike commented Apr 10, 2017

On Docker Hub, the image we were building from this Dockefile is listed as studionone/apache-php5. We have some projects which use this image, with FROM studionone/apache-php5 at the top of their Dockerfiles.

The only one I'm sure about is Explore at the moment. However, Explore uses this image as a base but replaces PHP5 with PHP7.

Since this image is now including PHP 7.1, we definitely shouldn't host it at studionone/apache-php5. We should probably setup studionone/apache-php and then tag our images so we have studionone/apache-php:7, studionone/apache-php:7.1, etc. We should then check through our other projects and see if we actually still need a PHP 5 build.

We could also set studionone/apache-php on Docker Hub as an automated build, so we don't have to build the image locally and upload it. Instead Docker Hub will rebuild each time we push a change to Github.

So… we can merge this, but when we do, we should also:

  • check other repos for FROM studionone/apache-php5
  • create studionone/apache-php on Docker Hub as an automated build
  • create a studionone/apache-php:7.1 build on Docker Hub
  • change Explore to use FROM studionone/apache-php:7.1
  • Rebuild Explore with the Docker Hub version of studionone/apache-php:7.1, then test lots

@ncraike ncraike merged commit c6bb804 into studionone:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants