0.35.0 Fixes

[bararchy]

Hi :)
with 0.35.0 the following https://github.com/stumpycr/stumpy_png/blob/master/src/stumpy_png/crc_io.cr#L18 should return Int64

Even:

def write(slice : Slice(UInt8)) : Int64
    @crc = CRC32.update(slice, @crc)
    @size += slice.size
    0_i64
  end

will be sufficient to compile

[asterite]

It should be:

  def write(slice : Slice(UInt8)) : Int64
    @crc = CRC32.update(slice, @crc)
    @size += slice.size
    slice.size.to_i64
  end

[bararchy]

PR ready at: #29 using @asterite's example

[bararchy]

just note (@l3kn)

[ptcodes]

I'm still having issues with Crystal 0.35.0

Specs also seem to be failing:

crystal spec                                                                                                                                                              ⏎ master ✖ ◼
Warning: Zlib is deprecated, use Compress::Zlib
Showing last frame. Use --error-trace for full trace.

There was a problem expanding macro 'getter'

Code in /usr/local/Cellar/crystal/0.35.0/src/file/error.cr:5:3

 5 | getter file : String
     ^
Called macro defined in macro 'macro_4453862464'

 117 | macro getter(*names, &block)

Which expanded to:

 > 2 |
 > 3 |
 > 4 |             @file : String
                   ^
Error: instance variable '@file' of Exception, with File::Error < Exception, is already declared as (String | Nil) (trying to re-declare as String)

[asterite]

This is a bug in minitest, it reopens Exception and adds file to it. minitest should remove that...