Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert IO#write changes in 0.35.0 and let it return Nil #9469

Merged
merged 5 commits into from
Jun 16, 2020

Conversation

bcardiff
Copy link
Member

Reverts #9233 and #9363, yet keeps some cleanup, minor fixes and the return type of IO.copy as Int64.

You can read the motivations for reverting these changes at #9233 (comment)

Although is a breaking-change from 0.35.0, it's better to revert it now than make all the ecosystem adapt for the change in 0.35.0. That's why it's better to do it in 0.35.1.

@bcardiff bcardiff added this to the 0.35.1 milestone Jun 12, 2020
@bcardiff
Copy link
Member Author

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants