Fix: Update dependency react-docgen #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new verison of react-docgen@next adds support for parsing flow function parameters without names. Eg. 'value: string => void'. Previously react-docgen was unable to parse files containing flow annotations like these, and therefore resulting in styleguidist being unable to render them.
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 101 101
Lines 1338 1338
Branches 271 271
=======================================
Hits 1285 1285
Misses 51 51
Partials 2 2Continue to review full report at Codecov.
|
|
Thanks, merged! |
tizmagik
added a commit
that referenced
this pull request
Oct 24, 2017
* master: Refactor: Replace Markdown links with the Link component instead of the styles (#650) Docs: Clarify logging in Node API (#637) Docs: Correct the `static` modifier note (#643) Docs: Explain behavior for code blocks w/o language tag (#642) Docs: Fix invalid prop type warning (#639) Fix: Clear console on example reload (#638) Docs: Add credits for logo designers (#636) Fix: Update react-docgen (#635) Fix: Correctly print non-Styleguidist exception messages Fix: Fix validation error for uglifyjs-webpack-plugin Docs: Remove react-modal dependency, tweak examples Docs: Update react-styleguidist in CRA example (#632) # Conflicts: # examples/basic/package-lock.json # examples/basic/package.json # examples/cra/package-lock.json # examples/customised/package-lock.json # examples/customised/package.json # examples/express/package-lock.json # examples/express/package.json # examples/sections/package-lock.json # examples/sections/package.json # examples/webpack/package-lock.json # examples/webpack/package.json # package-lock.json # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new verison of
react-docgen@nextadds support for parsing flowfunction parameters without names. Eg.
value: string => void.Previously react-docgen was unable to parse files containing flow
annotations like these, and therefore resulting in styleguidist being
unable to render them.