Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@PlatformIO Library Registry manifest file #41

Merged
merged 3 commits into from
May 29, 2016
Merged

@PlatformIO Library Registry manifest file #41

merged 3 commits into from
May 29, 2016

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Mar 29, 2016

Description

@fingolfin
Copy link
Collaborator

Your description is not very descriptive :-). In paticular, it remains unclear what this pull request is needed for? You link to http://platformio.org/lib/show/246/RCSwitch which seems to already have all the information you included in that library.json.

Hmm, it also seems this file only specifies Arduino as platform, but not Raspberry Pi, which gives a weird clash between description text and content... Ah well, not complaining, just observing :)

(Side remark: It's also somewhat unfortunate that platformio chose JSON as a standard, so one cannot put comments in that file, e.g. to explain that the file is related to platformio -- so if you don't know what the file is about, you can't easily find out

@ivankravets
Copy link
Contributor

@fingolfin What file format is comfortable for you?

In paticular, it remains unclear what this pull request is needed for?

The some user requested to add your library platformio/platformio-libmirror#45

@ivankravets
Copy link
Contributor

@valeros please extend manifest with

{
    "frameworks": [
        "arduino",
        "energia",
        "wiringpi"
    ],
    "platforms": "*"
}

@fingolfin
Copy link
Collaborator

I still don't see any explanation here why this is needed, and what it does.

If you want this to be merged, please explain what it does and why (on a higher level than "it adds this file"); for example, describe a usecase that is helped by this; describe a scenario where a user benefits from this, and how.

@bau-sec
Copy link
Contributor

bau-sec commented May 29, 2016

@fingolfin This registers rc-switch with PlatformIO so users can easily install the library from PlatformIO's CLI/IDE-plugin/etc. The reason you're seeing all the information posted on http://platformio.org/lib/show/246/RCSwitch is because the rc-switch library.json file is being sourced from https://github.com/valeros/rc-switch/blob/patch-1/library.json (the branch this PR is based on).

This patch should be merged (possibly with modifications to better specify compatible platforms and frameworks) and the PlatformIO registry should be updated to point to this repo instead. Otherwise the rc-switch authors aren't in control of the information provided to PlatformIO users about compatibility, version, authorship, etc.

For more info: http://docs.platformio.org/en/latest/librarymanager/creating.html

@fingolfin
Copy link
Collaborator

@bau-sec Thanks, at last somebody describe what this is about. So I am going to merge this, based on what you wrote. I'll not make any modifications, because quite frankly, I don't want to bother learning about platformio. But if you know how to use it and can come up with a reasonable pull request, of course we can merge that.

@fingolfin fingolfin merged commit 7e69f2b into sui77:master May 29, 2016
@ivankravets
Copy link
Contributor

@fingolfin thanks a lot that merged. I've just switched library config to original from this repository.

@bau-sec thank you too for explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants