Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the global style reset #2237

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove the global style reset #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b37c03
Remove the global style reset
connor-baer Sep 4, 2023
ae3e5af
Remove margins from typography components
connor-baer Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/circuit-ui/components/Body/Body.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.base {
margin: 0;
font-weight: var(--cui-font-weight-regular);
}

Expand Down
1 change: 1 addition & 0 deletions packages/circuit-ui/components/BodyLarge/BodyLarge.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.base {
margin: 0;
font-size: var(--cui-typography-body-large-font-size);
font-weight: var(--cui-font-weight-regular);
line-height: var(--cui-typography-body-large-line-height);
Expand Down
1 change: 1 addition & 0 deletions packages/circuit-ui/components/Headline/Headline.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.base {
margin: 0;
font-weight: var(--cui-font-weight-bold);
color: var(--cui-fg-normal);
letter-spacing: -0.03em;
Expand Down
1 change: 1 addition & 0 deletions packages/circuit-ui/components/List/List.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.base {
margin: 0;
font-weight: var(--cui-font-weight-regular);
}

Expand Down
1 change: 1 addition & 0 deletions packages/circuit-ui/components/SubHeadline/SubHeadline.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.base {
margin: 0;
font-size: var(--cui-typography-sub-headline-font-size);
font-weight: var(--cui-font-weight-bold);
line-height: var(--cui-typography-sub-headline-line-height);
Expand Down
1 change: 1 addition & 0 deletions packages/circuit-ui/components/Title/Title.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.base {
margin: 0;
font-weight: var(--cui-font-weight-bold);
color: var(--cui-fg-normal);
letter-spacing: -0.03em;
Expand Down
156 changes: 14 additions & 142 deletions packages/circuit-ui/styles/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,163 +1,35 @@
/* stylelint-disable no-duplicate-selectors -- Sections are split to separate third-party from first-party code */

/* Start downloading custom fonts as soon as possible */
@font-face {
font-family: aktiv-grotesk;
font-weight: 400;
src: url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-400.woff2') format('woff2'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-400.woff') format('woff'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-400.eot') format('embedded-opentype');
src: url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-400.woff2')
format('woff2'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-400.woff')
format('woff'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-400.eot')
format('embedded-opentype');
font-display: optional;
}

@font-face {
font-family: aktiv-grotesk;
font-weight: 700;
src: url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-700.woff2') format('woff2'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-700.woff') format('woff'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-700.eot') format('embedded-opentype');
src: url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-700.woff2')
format('woff2'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-700.woff')
format('woff'),
url('https://static.sumup.com/fonts/latin-greek-cyrillic/aktiv-grotest-700.eot')
format('embedded-opentype');
font-display: optional;
}

/**
* reset.css
* http://meyerweb.com/eric/tools/css/reset/
* v2.0 | 20110126
* License: none (public domain)
*/
html,
body,
div,
span,
applet,
object,
iframe,
h1,
h2,
h3,
h4,
h5,
h6,
p,
blockquote,
pre,
a,
abbr,
acronym,
address,
big,
cite,
code,
del,
dfn,
em,
img,
ins,
kbd,
q,
s,
samp,
small,
strike,
strong,
sub,
sup,
tt,
var,
b,
u,
i,
center,
dl,
dt,
dd,
ol,
ul,
li,
fieldset,
form,
label,
legend,
table,
caption,
tbody,
tfoot,
thead,
tr,
th,
td,
article,
aside,
canvas,
details,
embed,
figure,
figcaption,
footer,
header,
hgroup,
menu,
nav,
output,
ruby,
section,
summary,
time,
mark,
audio,
video {
padding: 0;
margin: 0;
font: inherit;
font-size: 100%;
vertical-align: baseline;
border: 0;
}

/* HTML5 display-role reset for older browsers */
article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
menu,
nav,
section {
display: block;
}

body {
line-height: 1;
}

blockquote,
q {
quotes: none;
}

blockquote::before,
blockquote::after,
q::before,
q::after {
content: '';
content: none;
}

table {
border-spacing: 0;
border-collapse: collapse;
}

/**
* Our global resets
*/

/**
* Best practice from http://callmenick.com/post/ the-new-box-sizing-reset
* TLDR: It’s easier to override and a slight performance boost.
* Best practice from http://callmenick.com/post/the-new-box-sizing-reset
* TL;DR: It’s easier to override and a slight performance boost.
*/
*,
*::before,
Expand Down
Loading