Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Chromatic builds #2357

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

connor-baer
Copy link
Member

Purpose

Based on https://storybook.js.org/blog/optimize-storybook-7-6/

Approach and changes

  • Enabled the new --test flag for Chromatic builds

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner December 21, 2023 16:31
Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: aa56608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 11:39am

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (f515f4e) to head (aa56608).
Report is 172 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2357   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files         198      198           
  Lines       21256    21256           
  Branches     1316     1316           
=======================================
  Hits        18657    18657           
  Misses       2547     2547           
  Partials       52       52           

This comment was marked as outdated.

@connor-baer
Copy link
Member Author

Enabling the --test flag causes RollupError: Expected 'from', got '=' 😕

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added the stale label May 13, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added the stale label Jul 15, 2024
@github-actions github-actions bot removed the stale label Jul 29, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added stale and removed stale labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant