Mark OID not increasing as invalid (librenms#13548)

* Mark OID not increasing as invalid * Provisional test data * verified return code is 1
sunblade · Nov 24, 2021 · 61eae8f · 61eae8f
1 parent 42fdbea
commit 61eae8f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/LibreNMS/Data/Source/SnmpResponse.php b/LibreNMS/Data/Source/SnmpResponse.php
@@ -68,7 +68,7 @@ public function isValid(): bool
     {
         $this->errorMessage = '';
         // not checking exitCode because I think it may lead to false negatives
-        $invalid = preg_match('/(Timeout: No Response from .*|Unknown user name|Authentication failure)/', $this->stderr, $errors)
+        $invalid = preg_match('/(Timeout: No Response from .*|Unknown user name|Authentication failure|Error: OID not increasing: .*)/', $this->stderr, $errors)
             || empty($this->raw)
             || preg_match('/(No Such Instance|No Such Object|No more variables left).*/', $this->raw, $errors);
 

diff --git a/tests/Unit/SnmpResponseTest.php b/tests/Unit/SnmpResponseTest.php
@@ -222,5 +222,10 @@ public function testErrorHandling(): void
         $response = new SnmpResponse('', "snmpget: Authentication failure (incorrect password, community or key) (Sub-id not found: (top) -> sysDescr)\n", 1);
         $this->assertFalse($response->isValid());
         $this->assertEquals('Authentication failure', $response->getErrorMessage());
+
+        // OID not increasing
+        $response = new SnmpResponse(".1.3.6.1.2.1.2.2.1.1.1 = INTEGER: 1\n", "Error: OID not increasing: .1.3.6.1.2.100.2.2.1.1\n >= .1.3.6.1.2.1.2.2.1.1.1\n", 1);
+        $this->assertFalse($response->isValid());
+        $this->assertEquals('Error: OID not increasing: .1.3.6.1.2.100.2.2.1.1', $response->getErrorMessage());
     }
 }