Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement floating point and string comparisons #673

Merged
merged 2 commits into from
Sep 6, 2024
Merged

implement floating point and string comparisons #673

merged 2 commits into from
Sep 6, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Sep 6, 2024

fixes #672

@coveralls
Copy link

Coverage Status

coverage: 81.3% (+0.2%) from 81.084%
when pulling d7df8ec on lovasoa:generalized_comparisons
into ecef974 on sunng87:master.

sunng87
sunng87 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 merged commit 7a99eea into sunng87:master Sep 6, 2024
9 checks passed
@lovasoa
Copy link
Contributor Author

lovasoa commented Sep 6, 2024

Thanks! When is the next release, so that I can synchronize it with SQLPage?

@sunng87
Copy link
Owner

sunng87 commented Sep 6, 2024

It has been released in 6.1.0. Just update it and verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

number comparison functions only accept integer values
3 participants
@lovasoa @coveralls @sunng87