Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle version prefix in globals #2701

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix: handle version prefix in globals #2701

merged 1 commit into from
Sep 21, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Sep 21, 2024 •
edited
Loading

What kind of change does this PR introduce?

Bug fix https://x.com/jonkkillian/status/1837153462548590920

What is the new behavior?

Allow 1_globals.sql to start with numeric prefix.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner September 21, 2024 07:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10970774655

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 60.022%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 10961056714: -0.03%
Covered Lines: 6456
Relevant Lines: 10756
💛 - Coveralls

@sweatybridge sweatybridge merged commit cd94f35 into develop Sep 21, 2024
13 checks passed
@sweatybridge sweatybridge deleted the skip-history branch September 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avallete avallete avallete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sweatybridge @coveralls @avallete