gl64 and bb31 face lift. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion is to use signed non-Montgomery constants to initialize bb31_t constants at compile time.
- reformat and harmonize with other implementations; - adjust prototypes and constant visibility; - add final_sub() method; - improve subtraction; - add compile-time constant to-Montgomery conversion;
dot-asm
force-pushed
the
gl64-n-bb31
branch
2 times, most recently
from
0d70654
to
ccbd388
Compare
|
Final call. I don't mean "provide feedback now [or never]," but rather I don't anticipate further changes [this time around]. |
(and harmonize naming in ntt.cuh to better readability)
Reserve signed integer for constant exponents not smaller than 2, typically literals such as x^7, and unsigned for variable exponents, typically x^threadIdx.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.