Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom storage key names #84

Merged
merged 12 commits into from
Jul 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/chilled-rules-float.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"mode-watcher": patch
"mode-watcher": minor
---

feat: Add `nonce` prop
5 changes: 5 additions & 0 deletions .changeset/slimy-mangos-complain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mode-watcher": minor
---

feat: Custom storage key names `modeStorageKey` `themeStorageKey`
2 changes: 1 addition & 1 deletion .changeset/tender-houses-enjoy.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"mode-watcher": patch
"mode-watcher": minor
---

feat: Add support for custom themes
36 changes: 18 additions & 18 deletions .github/ISSUE_TEMPLATE/1-documentation_change.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
name: Report Docs Issue
description: Suggest an addition or modification to the documentation
labels: ["documentation"]
labels: [documentation]
body:
- type: dropdown
attributes:
label: Change Type
description: What type of change are you proposing?
options:
- Addition
- Correction
- Removal
- Cleanup (formatting, typos, etc.)
validations:
required: true
- type: dropdown
attributes:
label: Change Type
description: What type of change are you proposing?
options:
- Addition
- Correction
- Removal
- Cleanup (formatting, typos, etc.)
validations:
required: true

- type: textarea
attributes:
label: Proposed Changes
description: Describe the proposed changes and why they are necessary
validations:
required: true
- type: textarea
attributes:
label: Proposed Changes
description: Describe the proposed changes and why they are necessary
validations:
required: true
42 changes: 21 additions & 21 deletions .github/ISSUE_TEMPLATE/2-feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
name: 🛠️ Request New Feature
description: Let us know what you would like to see added.
labels: ["enhancement"]
labels: [enhancement]
body:
- type: textarea
id: description
attributes:
label: Describe the feature in detail (code, mocks, or screenshots encouraged)
validations:
required: true
- type: dropdown
id: category
attributes:
label: What type of pull request would this be?
options:
- "New Feature"
- "Enhancement"
- "Guide"
- "Docs"
- "Other"
- type: textarea
id: references
attributes:
label: Provide relevant links or additional information.
- type: textarea
id: description
attributes:
label: Describe the feature in detail (code, mocks, or screenshots encouraged)
validations:
required: true
- type: dropdown
id: category
attributes:
label: What type of pull request would this be?
options:
- New Feature
- Enhancement
- Guide
- Docs
- Other
- type: textarea
id: references
attributes:
label: Provide relevant links or additional information.
102 changes: 51 additions & 51 deletions .github/ISSUE_TEMPLATE/3-bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,53 +1,53 @@
name: "🐛 Bug report"
name: 🐛 Bug report
description: Report an issue with mode-watcher
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: textarea
id: bug-description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is. If you intend to submit a PR for this issue, tell us how in the description. Thanks!
placeholder: Bug description
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Reproduction
description: |
Please provide a link to a repo or Stackblitz that can reproduce the problem you ran into. If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "needs reproduction" label. If no reproduction is provided within a reasonable time-frame, the issue will be closed.
To get started, you can use the following StackBlitz template:
https://mode-watcher.svecosystem.com/repro
placeholder: Reproduction
validations:
required: true
- type: textarea
id: logs
attributes:
label: Logs
description: "Please include browser console and server logs around the time this bug occurred. Optional if provided reproduction. Please try not to insert an image but copy paste the log text."
render: bash
- type: textarea
id: system-info
attributes:
label: System Info
description: Output of `npx envinfo --system --npmPackages svelte,mode-watcher,@sveltejs/kit --binaries --browsers`
render: bash
placeholder: System, Binaries, Browsers
validations:
required: true
- type: dropdown
id: severity
attributes:
label: Severity
description: Select the severity of this issue
options:
- annoyance
- blocking an upgrade
- blocking all usage of mode-watcher
validations:
required: true
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: textarea
id: bug-description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is. If you intend to submit a PR for this issue, tell us how in the description. Thanks!
placeholder: Bug description
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Reproduction
description: |
Please provide a link to a repo or Stackblitz that can reproduce the problem you ran into. If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "needs reproduction" label. If no reproduction is provided within a reasonable time-frame, the issue will be closed.

To get started, you can use the following StackBlitz template:
https://mode-watcher.svecosystem.com/repro
placeholder: Reproduction
validations:
required: true
- type: textarea
id: logs
attributes:
label: Logs
description: Please include browser console and server logs around the time this bug occurred. Optional if provided reproduction. Please try not to insert an image but copy paste the log text.
render: bash
- type: textarea
id: system-info
attributes:
label: System Info
description: Output of `npx envinfo --system --npmPackages svelte,mode-watcher,@sveltejs/kit --binaries --browsers`
render: bash
placeholder: System, Binaries, Browsers
validations:
required: true
- type: dropdown
id: severity
attributes:
label: Severity
description: Select the severity of this issue
options:
- annoyance
- blocking an upgrade
- blocking all usage of mode-watcher
validations:
required: true
12 changes: 6 additions & 6 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: Get Help
url: https://github.com/huntabyte/mode-watcher/discussions/new?category=help
about: If you can't get something to work the way you expect, open a question in our discussion forums.
- name: Discord
url: https://discord.gg/rePvPCE9dh
about: If you need to have a back-and-forth conversation, join the Discord server.
- name: Get Help
url: https://github.com/huntabyte/mode-watcher/discussions/new?category=help
about: If you can't get something to work the way you expect, open a question in our discussion forums.
- name: Discord
url: https://discord.gg/rePvPCE9dh
about: If you need to have a back-and-forth conversation, join the Discord server.
71 changes: 53 additions & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,32 +15,67 @@ permissions:
contents: read # to fetch code (actions/checkout)

jobs:
Lint:
Check:
name: Run svelte-check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 8.6.3
run_install: true
- run: pnpm build:packages && pnpm lint
version: 8
run_install: false

Check:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm

- name: Install dependencies
run: pnpm install

- name: Run svelte-check
run: pnpm check
Lint:
runs-on: ubuntu-latest
name: Lint
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 8.6.3
run_install: true
- run: pnpm check
version: 8
run_install: false

Tests:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm

- name: Install dependencies
run: pnpm install

- run: pnpm lint

Test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 8.6.3
run_install: true
- run: pnpm run test
version: 8
run_install: false

- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm

- name: Install dependencies
run: pnpm install

- run: pnpm test
Loading
Loading