Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore dist folders from lint check #11155

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

bfanger
Copy link
Contributor

@bfanger bfanger commented Dec 1, 2023

Running the test before running lint results in:

│ [warn] test/fixtures/javascript/dist/index.d.ts
│ [warn] test/fixtures/javascript/dist/internal/index.d.ts
│ [warn] test/fixtures/javascript/dist/internal/Test.svelte.d.ts
│ [warn] test/fixtures/javascript/dist/Test.svelte.d.ts
│ [warn] test/fixtures/javascript/dist/Test2.svelte.d.ts
│ [warn] test/fixtures/resolve-alias/dist/baz.d.ts
│ [warn] test/fixtures/resolve-alias/dist/sub/bar.d.ts
│ [warn] test/fixtures/resolve-alias/dist/sub/foo.d.ts
│ [warn] test/fixtures/resolve-alias/dist/Test.svelte
│ [warn] test/fixtures/resolve-alias/dist/Test.svelte.d.ts
│ [warn] test/fixtures/resolve-alias/dist/utils/index.js
│ [warn] test/fixtures/svelte-3-types/dist/Test.svelte
│ [warn] test/fixtures/svelte-3-types/dist/Test.svelte.d.ts
│ [warn] test/fixtures/svelte-kit/dist/index.d.ts
│ [warn] test/fixtures/svelte-kit/dist/Test.svelte.d.ts
│ [warn] test/fixtures/typescript-esnext/dist/Plain.svelte.d.ts
│ [warn] test/fixtures/typescript-esnext/dist/Test.svelte
│ [warn] test/fixtures/typescript-esnext/dist/Test.svelte.d.ts
│ [warn] test/fixtures/typescript-esnext/dist/Test2.svelte
│ [warn] test/fixtures/typescript-esnext/dist/Test2.svelte.d.ts
│ [warn] test/fixtures/typescript-nodenext/dist/Test.svelte
│ [warn] test/fixtures/typescript-nodenext/dist/Test.svelte.d.ts
│ [warn] Code style issues found in 22 files. Run Prettier to fix.
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @sveltejs/package@2.2.3 lint: `prettier --check .`
Exit status 1
 ELIFECYCLE  Command failed with exit code 1.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: ab35aad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title fix: Ignore dist folders from linting check fix: ignore dist folders from lint check Dec 1, 2023
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked how this was implemented. Didn't test it, but pretty sure it should work

@bfanger
Copy link
Contributor Author

bfanger commented Dec 1, 2023

Interesting, using the .gitignore to help prettier to ignore the dist files.
It works as expected 👍

@benmccann benmccann merged commit 1926f4b into sveltejs:master Dec 1, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants