Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude service worker directory from tsconfig #12196

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

gurpreetatwal
Copy link
Contributor

@gurpreetatwal gurpreetatwal commented May 7, 2024

The docs state that the service worker can be located at src/service-worker.js or as an index.js file within the src/service-worker directory.

Without this fix users who place the file within the directory run into Typescript errors like #11721

Follow up to #11727

Question for maintainers: Should all js/ts files in the service-worker directory be excluded or only index.js|ts|d.ts?


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

The [docs](https://kit.svelte.dev/docs/service-workers) state that the
service worker can be located at `src/service-worker.js` or as an
`index.js` file within the `src/service-worker` directory.

Without this fix users who place the file within the directory run into
Typescript errors like
[#11721](https://github.com/sveltejs/kit/issues/117210)

Follow up to [#11727](#11727)
Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 144ff71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gurpreetatwal
Copy link
Contributor Author

@dummdidumm, @trueadm , @eltigerchino sorry for the ping but would one of you be able to take a look at this PR?

@dummdidumm dummdidumm merged commit 108cb12 into sveltejs:main Aug 29, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
@eltigerchino
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service worker Stuff related to service workers types / typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants