Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getters #6237

Merged
merged 6 commits into from
Aug 25, 2022
Merged

remove getters #6237

merged 6 commits into from
Aug 25, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Aug 24, 2022

Closes #6199
Closes #6126

Something we noticed recently is that our use of accessors on RequestEvent and LoadEvent made it difficult to do this sort of thing:

const augmented_event = { ...event, extra_stuff };

On RequestEvent, we had get clientAddress — this PR changes that to getClientAddress, which is a breaking change.

On LoadEvent, we previously had get url. But we don't actually need to track whether url was accessed, just whether its properties were accessed (and only the properties that could change during a session — not url.origin etc), allowing load functions to be more conservative about when they re-run.

I also noticed we weren't previously tracking url access when loading server data, which is now fixed.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2022

🦋 Changeset detected

Latest commit: cd4bbc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one minor detail which could be cleaned up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants