-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate dynamic env types #6413
Conversation
🦋 Changeset detectedLatest commit: 5d50358 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
'@sveltejs/kit': patch | ||
--- | ||
|
||
[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types | |
[breaking] remove App.PrivateEnv and App.PublicEnv in favor of generated types |
Filthy european
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇬🇧
'@sveltejs/kit': patch | ||
--- | ||
|
||
[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[breaking] remove App.PrivateEnv and App.PublicEnv in favour of generated types | |
[breaking] remouve App.PrivateEnv and App.PublicEnv in favour of generated types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇬🇧
All joking aside, LGTM. edit: Assuming Safari issues are just flakiness |
Closes #6202.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0