-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6842: Routes were not found by id under group layouts #6843
Conversation
Fixes sveltejs#6842: Types are not properly updated for routes under group layouts routes were not found by id under group layouts. replacing '\' with '/' fixes this for route id's.
🦋 Changeset detectedLatest commit: cda5cb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone with more insight might tell if this is the best fix or if there needs to be some other update to the route id pattern matchers. |
I assume this is a Windows-only issue because of the |
Correct, just verified that the issue does not occur on my MacBook. |
thank you! |
Thank you! We’re a team of 25 students all on windows just getting started with SK the last few months so happy to keep enjoying this great DX 🎉👌 |
Umh. Actually this doesn't work on windows. Can we do this instead? It actually works (on windows). Also verified on mac. const id = posixify(path.relative(config.kit.files.routes, path.dirname(file))); |
Fixes #6842 - Types are not properly updated for routes under group layouts
Routes were not found by id under group layouts. replacing '' with '/' fixes this for route id's.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0