Fixes #6842: Routes were not found by id under group layouts

[williamviktorsson]

Fixes #6842 - Types are not properly updated for routes under group layouts

Routes were not found by id under group layouts. replacing '' with '/' fixes this for route id's.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

🦋 Changeset detected

Latest commit: cda5cb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[williamviktorsson]

Someone with more insight might tell if this is the best fix or if there needs to be some other update to the route id pattern matchers.

[Conduitry]

I assume this is a Windows-only issue because of the / and the \? To be in line with how this sort of thing is being handled elsewhere in the codebase, we should be normalizing id with the posixify() function being used elsewhere, and then continue to compare it with the path route IDs as we are now.

[williamviktorsson]

I assume this is a Windows-only issue because of the / and the \? To be in line with how this sort of thing is being handled elsewhere in the codebase, we should be normalizing id with the posixify() function being used elsewhere, and then continue to compare it with the path route IDs as we are now.

Correct, just verified that the issue does not occur on my MacBook.

[Rich-Harris]

thank you!

[williamviktorsson]

thank you!

Thank you! We’re a team of 25 students all on windows just getting started with SK the last few months so happy to keep enjoying this great DX 🎉👌

[williamviktorsson]

Umh. Actually this doesn't work on windows.

Can we do this instead? It actually works (on windows). Also verified on mac.

const id = posixify(path.relative(config.kit.files.routes, path.dirname(file)));