-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] check for private var usage in client code instead of server code #7487
Conversation
🦋 Changeset detectedLatest commit: e39a673 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make sense to move ssrLoadModule
only after checking the illegal imports.
Could we add some comments explaining why we use this other method, and use |
ok. I added a couple comments |
Fixes #7288
Don't put the module into the graph with
ssrLoadModule
which will add the server-side code, but instead useensureEntryFromUrl
leaving thessr
parameterundefined