Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change windows image for faster CI #8630

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link
Member

let's see if this speeds things up

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2023

⚠️ No Changeset found

Latest commit: 479b4e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

You need to --force turbo to not use the cache to see if this helped

@Rich-Harris
Copy link
Member

You need to --force turbo to not use the cache to see if this helped

The OS is part of the cache key, so this worked correctly (the Windows tests ran, everything else was FULL TURBO):

TURBO_CACHE_KEY: ${{ matrix.os }}-${{ matrix.node-version }}

18 minutes — not that much different :(

@benmccann benmccann closed this Jan 20, 2023
@benmccann benmccann deleted the windows-ci branch January 20, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants