Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) don't format class attribute #145

Merged
merged 2 commits into from
Sep 24, 2020
Merged

(fix) don't format class attribute #145

merged 2 commits into from
Sep 24, 2020

Conversation

dummdidumm
Copy link
Member

Prettier HTML does not format attributes at all and to be consistent we should not format it, too.

@dummdidumm
(fix) don't format class attribute
0aefb00 
Prettier HTML does not format attributes at all and to be consistent we should not format it, too.
@dummdidumm
fix test
a1114e6
@dummdidumm dummdidumm merged commit 4359fa1 into master Sep 24, 2020
@dummdidumm dummdidumm deleted the dont-format-class-attr branch September 24, 2020 13:21
@ehrencrona
Copy link
Contributor

ehrencrona commented Sep 24, 2020 •
edited
Loading

It doesn't line break, but it does trim:

<div class=" a b c "></div>

formats to

<div class="a b c"></div>

But it's pretty marginal I guess.

@Conduitry Conduitry mentioned this pull request Feb 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dummdidumm @ehrencrona