-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for docExpansion config #3159
Conversation
@gwynjudd Thanks for taking the time to write this PR. While @shockey reviews it, I was wondering whether you have the time to implement the full functionality of Regardless, please add the |
@webron I updated it to support the other doc expansion settings 'full' and 'list', but I got stuck with an unexpected bug on 'full'. The first time it loads the page, it appears as this: On debugging, it appears that the operations list loads and displays correctly, but at the very last, it is replaced with an empty list which for some reason renders as this. I got stuck trying to follow the logic of how the operations list is created and how this might be happening. If you have any suggestions, please let me know |
Huh, interesting. @shockey? |
Digging in! |
So, this was a fun one to track down..
Those three selectors are composites of the an unrelated call to the paths: {
'/pet': {
post: {
parameters: [
{}
],
produces_value: 'application/xml'
}
}
} This causes the next call to That's also the reason that we were seeing one operation, the To fix this, I removed the switching logic from the This didn't appear to break anything, but I'll do some more extensive testing before merging and before releasing. |
@gwynjudd thanks for all the work you've put into it, definitely helped us move forward. Hoping to see future contributions from you as well, time permitting of course :) |
Resolves #2799