Skip to content

Commit

Permalink
fix(es/minifier): Add WeakRef as a safe global reference (#8458)
Browse files Browse the repository at this point in the history
**Description:**

I was trying to remove references to Weak Ref from minified code and
despite the expression not being used, it was still included.

E.g.
```
var x = WeakRef;
```
with

```
{
   "minify": true,
  "jsc": {
      "minify": {
            "compress": {
                "pure_getters": true,
                "unused": true
            },
            "mangle": true
        }
    }
}
```
outputs

```
WeakRef;
```

but when I use something on this list e.g. parseFloat, it gets cleaned
up and outputs empty string.

btw - I tried different options for pure_getters that I assumed would
allow me to say WeakRef as a getter was pure, but it had no effect.

WeakRef getter is as safe to remove as the other items on this list and
has no effect in accessing it.
  • Loading branch information
lukeapage committed Dec 29, 2023
1 parent 4229e7b commit d681785
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crates/swc_ecma_usage_analyzer/src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ pub fn is_global_var_with_pure_property_access(s: &str) -> bool {
| "NaN"
| "Symbol"
| "Promise"
| "WeakRef"
)
}

Expand Down

0 comments on commit d681785

Please sign in to comment.