fix unclosed rows

Makefile

@@ -49,3 +49,10 @@ test-sqlite: install
 	cd internal/integration && go test ./...
 
 test: test-postgresql test-sqlite test-mysql
+
+test-migrate: install
+	rm -rf internal/migrate/db internal/migrate/test.sqlite3
+	cd internal/migrate && queryx db:migrate --schema sqlite1.hcl
+	sleep 1
+	cd internal/migrate && queryx db:migrate --schema sqlite2.hcl
+	cd internal/migrate && sqlite3 test.sqlite3 "insert into users(name, email) values('test', 'test@example.com')"

adapter/migrator.go

@@ -99,6 +99,10 @@ func (m *Migrator) exists(ctx context.Context, version string) (bool, error) {
 	if !rows.Next() {
 		exists = false
 	}
+	if err := rows.Close(); err != nil {
+		return false, fmt.Errorf("closing rows %w", err)
+	}
+
 	return exists, nil
 }
 

cmd/queryx/action/db.go

@@ -32,7 +32,6 @@ func newAdapter() (adapter.Adapter, error) {
 	return adapter.NewAdapter(sch.Databases[0].LoadConfig(environment))
 }
 
-// TODO: should check unapplied migrations
 func findSchemaChanges(a string, db adapter.Adapter, database *schema.Database) ([]*migrate.Change, error) {
 	ctx := context.Background()
 
@@ -141,17 +140,15 @@ var dbMigrateCmd = &cobra.Command{
 		if err := a.Open(); err != nil {
 			return err
 		}
-		defer a.Close()
+		// defer a.Close()
 
 		migrator, err := adapter.NewMigrator(a)
 		if err != nil {
 			return err
 		}
-
 		if err := migrator.Up(); err != nil {
 			return err
 		}
-
 		if err := dbMigrateGenerate(); err != nil {
 			return err
 		}
@@ -187,6 +184,7 @@ func dbMigrateGenerate() error {
 	if err := adapter.Open(); err != nil {
 		return err
 	}
+	// defer adapter.Close()
 
 	database := sch.Databases[0]
 	changes, err := findSchemaChanges(sch.Databases[0].Adapter, adapter, database)

internal/migrate/sqlite1.hcl

@@ -6,6 +6,8 @@ database "db" {
   }
 
   model "User" {
+    timestamps = false
+
     column "name" {
       type = string
     }

internal/migrate/sqlite2.hcl

@@ -6,6 +6,8 @@ database "db" {
   }
 
   model "User" {
+    timestamps = false
+
     column "name" {
       type = string
     }