reuse pool connection when creating transaction

swiftcarrot · Sep 1, 2024 · f69465d · f69465d
1 parent daceaa1
commit f69465d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 17 deletions.
diff --git a/generator/client/typescript/templates/queryx/adapter.mysql.ts b/generator/client/typescript/templates/queryx/adapter.mysql.ts
@@ -6,7 +6,6 @@ import { Config } from "./config";
 
 export class Adapter {
   public config: Config;
-  public pool: mysql.Pool;
   public db: mysql.Pool;
 
   constructor(config: Config) {
@@ -17,14 +16,9 @@ export class Adapter {
     const pool = mysql.createPool({
       uri: this.config.url,
     });
-    this.pool = pool;
     this.db = pool;
   }
 
-  newClient() {
-    return this.pool.getConnection();
-  }
-
   release() {
     this.db.release();
   }

diff --git a/generator/client/typescript/templates/queryx/adapter.postgresql.ts b/generator/client/typescript/templates/queryx/adapter.postgresql.ts
@@ -8,7 +8,6 @@ pg.types.setTypeParser(pg.types.builtins.INT8, (val) => parseInt(val, 10));
 
 export class Adapter {
   public config: Config;
-  public pool?: pg.Pool;
   public db?: pg.Pool;
 
   constructor(config: Config) {
@@ -19,14 +18,9 @@ export class Adapter {
     const pool = new pg.Pool({
       connectionString: this.config.url,
     });
-    this.pool = pool;
     this.db = pool;
   }
 
-  newClient() {
-    return this.pool.connect();
-  }
-
   release() {
     this.db.release();
   }

diff --git a/generator/client/typescript/templates/queryx/adapter.sqlite.ts b/generator/client/typescript/templates/queryx/adapter.sqlite.ts
@@ -16,10 +16,6 @@ export class Adapter {
     this.db = new Database(this.config.url);
   }
 
-  newClient() {
-    return new Database(this.config.url);
-  }
-
   release() {}
 
   query<R>(query: string, ...args: any[]): R[] {

diff --git a/generator/client/typescript/templates/queryx/client.tstmpl b/generator/client/typescript/templates/queryx/client.tstmpl
@@ -67,7 +67,7 @@ export class QXClient {
 
   async tx() {
     const tx = new Tx(this.config);
-    tx.adapter.db = await this.adapter.newClient();
+    tx.adapter.db = await this.adapter.db;
     await tx.adapter.beginTx();
     return tx;
   }