[clang][CodeGen] Check initializer of zero-size fields for nullptr #9313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In llvm#96422 we started treating empty records as zero-sized for the purpose of layout. In
C
, empty fields were never consideredisZeroSize
, so we would never have tried to callInit->hasSideEffects
on them. But sincellvm#96422 we can get here when compiling
C
, butInit
need not exist. This patch adds a null-check to account for this situtation.(cherry picked from commit 2162a18)