[Constant Evaluator] Add support for string appends and string equals to the constant evaluator #22147
Conversation
ravikandhadai
requested review from
jckarter,
devincoughlin,
marcrasi and
eeckstein
ravikandhadai
force-pushed
the
consteval-string-append
branch
from
ecc3056
to
2c0627e
Compare
the constant evaluator.
ravikandhadai
force-pushed
the
consteval-string-append
branch
from
2c0627e
to
ee222c3
Compare
| if (literal.getKind() != SymbolicValue::String) { | ||
| return evaluator.getUnknown((SILInstruction *)apply, | ||
| UnknownReason::Default); | ||
| } |
There was a problem hiding this comment.
@marcrasi I added support for String.+= and also String.==. In addition to that I also changed the breaks here to return unknown. I wasn't sure why there was a break here? But, it seemed to me that it was perhaps because there are two functions with "makeUTF8" semantics attribute and the evaluator is handling just one of them. But, it turns out that the other one is also identical (in terms of semantics) and is redundant and is probably unused.
There was a problem hiding this comment.
Ah, break is mistakenly left over from before I refactored the switch into its own function. It made sense in context of the the switch's original location, but it no longer makes sense.
|
@swift-ci Please smoke test |
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
This PR adds support for string appends and string equals to the constant evaluator. It adds new @_semantics attributes to the standard library functions:
String.+=andString.==and models these operations in the evaluator.