[cmake] No depends on intrinsics_gen in standalone #5112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intrinsics_gen target exists only when building Swift "in tree" -- that is, when building Swift within the LLVM source tree. Adding a non-existent intrinsics_gen target in "out of tree" builds results in CMake warning (which are upgraded to hard errors in later versions of CMake, such as 3.4.3). Prevent the non-existent intrinsics_gen target from being added in out of tree builds by defining a separate list of common dependencies, SWIFT_COMMON_DEPENDS, and using this in place of LLVM_COMMON_DEPENDS. I've added FIXMEs where LLVM functions use LLVM_COMMON_DEPENDS internally, without allowing dependencies to be specified by callers. Alternatively, it may be possible to simply remove the intrinsics_gen target from the LLVM_COMMON_DEPENDS list when building out of tree. I opted to not pursue this option, since it would involve mutating a global list that may be repercussions elsewhere.
|
I've committed r283234 to LLVM trunk, which should resolve this issue. What is the process for getting that merged into swift-llvm/stable? |
|
I pushed the llvm fix into swift-3.1-branch, and it should make its way into swift/stable. I believe that will make this change unnecessary. |
|
Awesome! Thanks, @llvm-beanz! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
intrinsics_gentarget exists only when building Swift "in tree" -- that is, when building Swift within the LLVM source tree. Adding a non-existentintrinsics_gentarget in "out of tree" builds results in CMake warning (which are upgraded to hard errors in later versions of CMake, such as 3.4.3).Prevent the non-existent
intrinsics_gentarget from being added in out of tree builds by defining a separate list of common dependencies,SWIFT_COMMON_DEPENDS, and using this in place ofLLVM_COMMON_DEPENDS. I've added FIXMEs where LLVM functions useLLVM_COMMON_DEPENDSinternally, without allowing dependencies to be specified by callers.Alternatively, it may be possible to simply remove the
intrinsics_gentarget from theLLVM_COMMON_DEPENDSlist when building out of tree. I opted to not pursue this option, since it would involve mutating a global list that may be repercussions elsewhere.This addresses a suggestion left by @gottesmm and @llvm-beanz on #4999.