[SymbolGraphGen] move "protocol implementations" check into isImplicitlyPrivate #64867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://107432084
|
@swift-ci Please smoke test |
| namespace { | ||
|
|
||
| const ValueDecl *getProtocolRequirement(const ValueDecl *VD) { | ||
| auto reqs = VD->getSatisfiedProtocolRequirements(); |
There was a problem hiding this comment.
mega nit, llvm code bases tend to do locals in ThisKindOfCamelCase
There was a problem hiding this comment.
This code's copy/pasted from Symbol::getProtocolRequirement, which (IIRC) was itself a refactoring of existing code. I can change it if you want, but i'd be touching some other places too.
There was a problem hiding this comment.
ah don't worry about it then.
| @@ -45,3 +49,15 @@ public struct SomeStruct: SomeProtocol { | |||
| /// Local docs | |||
| public func otherFunc() {} | |||
| } | |||
|
|
|||
| // Make sure that protocol conformances added in extensions don't create bogus symbol relationships (rdar://107432084) | |||
There was a problem hiding this comment.
can you add a test that checks that we are still emitting it for one that has it's own doc comment?
There was a problem hiding this comment.
Pushed a commit that adds this to the test.
|
@swift-ci Please smoke test |
daniel-grumberg
approved these changes
Apr 4, 2023
QuietMisdreavus
added a commit
that referenced
this pull request
Apr 5, 2023
…tlyPrivate (#64867) rdar://107432084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://107432084
The original implementation of
-skip-protocol-implementationsfocused on dropping symbols that matched the description of "protocol implementation", but didn't extend the check to any extra relationships that can show up. This meant that if a "protocol implementation" symbol is a type that adds a protocol implementation via an extension, that protocol conformance still ends up in the symbol graph, creating a malformed graph where a relationship references a symbol that doesn't exist. This PR moves the "protocol implementation" check intoSymbolGraph::isImplictlyPrivate, alongside the other checks for dropping a symbol, to catch these scenarios.