Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new parameter convention @in_cxx for non-trivial C++ classes that are passed indirectly and destructed by the caller #73019

Merged
merged 10 commits into from
Jun 27, 2024
+736 −45
Merged

Add a new parameter convention @in_cxx for non-trivial C++ classes that are passed indirectly and destructed by the caller #73019

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e86a0a0
Add a new parameter convention `@in_cxx` for non-trivial C++ classes
ahatanaka Apr 23, 2024
8b63e98
Address feedback from @atrick and @nate-chandler
ahatanaka May 16, 2024
4dfb1e0
Add type attribute for @in_cxx
ahatanaka May 17, 2024
191dc92
Emit destroy_addr when inlining a function that has @in_cxx parameters
ahatanaka May 17, 2024
187a95b
Fix mangling of @in_cxx
ahatanaka May 17, 2024
3d102ed
Add missing case
ahatanaka May 17, 2024
cf33eef
Fix function names in tests after mangling change
ahatanaka May 18, 2024
be51347
Fix tests
ahatanaka May 30, 2024
242ee1b
Fix check strings
ahatanaka May 30, 2024
4d6a47f
Fix isConsumedParameter, etc.
ahatanaka Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing case
  • Loading branch information
@ahatanaka
ahatanaka committed Jun 26, 2024
commit 3d102ed9d3be241893c2aed887fd15d0e4aa4995
2 changes: 1 addition & 1 deletion SwiftCompilerSources/Sources/SIL/Argument.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ public enum ArgumentConvention : CustomStringConvertible {

public var isConsumed: Bool {
switch self {
case .indirectIn, .directOwned, .packOwned:
case .indirectIn, .indirectInCXX, .directOwned, .packOwned:
return true
case .indirectInGuaranteed, .directGuaranteed, .packGuaranteed,
.indirectInout, .indirectInoutAliasable, .indirectOut,
Expand Down