More preconcurrency fixes #73738
Merged
More preconcurrency fixes #73738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "send non-Sendable" pass had a copy of the code for determining what limit to put on the diagnostic behavior for a given reference to a nominal type declaration. Rather than update that copy for the recent changes to the canonical version of this in the type checker, share the computation.
When a retroactive conformance to a protocol that inherits from `Sendable` introduces an implicit `Sendable` conformance, allow `@preconcurrency` to suppress the diagnostic about the `Sendable` conformance being introduced outside of the original source file. Fixes rdar://125080066.
DougGregor
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce more pre concurrency fixes:
@preconcurrencyapplies between SIL-based diagnostics and type checker diagnostics@preconcurrencyto suppress a warning about a retroactive impliedSendableconformance.Fixes rdar://125080066.