Don't diagnose accesses to global/static variables within the same module #73740
+29
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
…dule When SE-0412 (strict concurrency for global variables) is enabled, each global or static mutable variable will be diagnosed if it isn't explicitly on a global actor or `nonisolated(unsafe)`. Suppress diagnostics for references to such global variables when they are in the same module as the declaration of the global variable itself. While these diagnostics are technically correct, they are not strictly necessary since we've already diagnosed the global variable itself (with more actionable advice), and they tend to pile on the developer in a manner that is not helpful.
DougGregor
force-pushed
the
suppress-global-shared-state-diags-in-module
branch
from
a0d7726
to
e1a4a1e
Compare
|
GitHub failed to stack PRs despite no differences; this already passed all PR testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SE-0412 (strict concurrency for global variables) is enabled, each
global or static mutable variable will be diagnosed if it isn't
explicitly on a global actor or
nonisolated(unsafe).Suppress diagnostics for references to such global variables when they
are in the same module as the declaration of the global variable
itself. While these diagnostics are technically correct, they are not
strictly necessary since we've already diagnosed the global variable
itself (with more actionable advice), and they tend to pile on the
developer in a manner that is not helpful.