-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IRGen] Return typed errors directly in synchronous functions when po… #74192
Conversation
This definitely needs some cleanups and code deduplication, but ready for first review pass. |
@@ -338,6 +347,22 @@ void IRGenThunk::emit() { | |||
|
|||
emission->end(); | |||
|
|||
// FIXME: we shouldn't have to generate all of this. We should just forward | |||
// the value as is | |||
if (auto &error = emission->getTypedErrorExplosion()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary. This should really be a tail call.
Please test with following pull request: @swift-ci smoke test |
4aba6ae
to
99b0e83
Compare
Please test with following pull request: @swift-ci smoke test |
…ssible rdar://129359355 This PR implements the basic support for returning typed errors directly and applies it to synchronous functions.
99b0e83
to
d9bc2cb
Compare
Please test with following pull request: @swift-ci smoke test |
Please test with following pull request: @swift-ci smoke test |
…ssible
rdar://129359355
This PR implements the basic support for returning typed errors directly and applies it to synchronous functions.